Skip to content

refactor: support ansible 2.19; fix ansible-lint issues #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richm merged 1 commit into from
Jul 9, 2025
Merged

refactor: support ansible 2.19; fix ansible-lint issues #295

richm merged 1 commit into from
Jul 9, 2025

Conversation

@richm
Copy link
Collaborator

@richm richm commented Jul 9, 2025 •
edited by sourcery-ai bot
Loading

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update tests for Ansible 2.19 compatibility and address ansible-lint issues by renaming variables and clarifying task names.

Tests:

  • Use "__ansible_managed" instead of "ansible_managed" in header assertion to comply with linting and Ansible 2.19 conventions
  • Rename NTP provider verification task to "Verify provider set correctly - 2" to avoid duplicate task names

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 9, 2025 •
edited
Loading

Reviewer's Guide

Refactor tests to support Ansible 2.19 managed header variable naming and fix ansible-lint issues by updating variable names and test descriptions.

File-Level Changes

Change Details Files
Adjust ansible managed header variables to comply with Ansible 2.19 changes
  • Replaced ansible_managed with __ansible_managed in assert condition
  • Updated variable lookup key to __ansible_managed
 tests/tasks/check_header.yml
Rename test case to avoid duplicate names and satisfy lint rules
  • Appended '- 2' to test name 'Verify provider set correctly'
 tests/tests_ntp_provider6.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 9, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Collaborator Author

richm commented Jul 9, 2025

[citest]

@richm richm merged commit 82053a7 into linux-system-roles:main Jul 9, 2025
27 checks passed
@richm richm deleted the fix-ansible-2.19 branch July 9, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@richm